fix(editor): fix window close logic and lambda capture#477
Merged
lzwind merged 1 commit intoJun 11, 2026
Merged
Conversation
Fix window close timing by checking tabbar count instead of just wrappers. Use proper lambda capture [this] to avoid StartManager::instance() race condition. 修复窗口关闭时机判断，添加标签页计数检查。 修复lambda捕获问题，使用this指针避免instance()竞态条件。 Log: 修复窗口关闭逻辑 PMS: BUG-365421 Influence: 修复编辑器关闭时可能出现的窗口未正确关闭问题，提升应用稳定性。
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
lzwind
approved these changes
Jun 11, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix window close timing by checking tabbar count instead of just wrappers. Use proper lambda capture [this] to avoid StartManager::instance() race condition.
修复窗口关闭时机判断，添加标签页计数检查。
修复lambda捕获问题，使用this指针避免instance()竞态条件。
Log: 修复窗口关闭逻辑
PMS: BUG-365421
Influence: 修复编辑器关闭时可能出现的窗口未正确关闭问题，提升应用稳定性。